Fix cu signal handler #3349
Merged
Fix cu signal handler #3349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sigint() function uses siginfo->si_user but was declared with only one parameter (int sig). This causes compilation error because siginfo is undeclared. Fix by: 1. Rename sigint to cu_exit with proper sigaction signature 2. Use sa_sigaction instead of sa_handler to receive siginfo_t 3. Pass cu pointer via sa.sa_user for signal handler access Signed-off-by: makejian <[email protected]>
ThePassionate
force-pushed
the
fix-cu-signal-handler
branch
from
6751182 to
f8c30c6
Compare
Merge the cu.h header file contents into cu_main.c to simplify the code structure. The cu_globals_s structure and related definitions are now directly in cu_main.c. Signed-off-by: guoshichao <[email protected]>
ThePassionate
force-pushed
the
fix-cu-signal-handler
branch
from
f8c30c6 to
f02f26e
Compare
xiaoxiang781216
approved these changes
Jan 20, 2026
jerpelea
approved these changes
Jan 20, 2026
simbit18
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the compilation error in system/cu and simplifies code structure:
Fix signal handler to use sa_sigaction - The previous commit
782de2748fintroduced a bug wheresigint()function usessiginfo->si_userbut was declared with only one parameter(int sig). This causes compilation error becausesiginfois undeclared. Fixed by usingsa_sigactionwith proper 3-parameter signature to receive siginfo_t.Merge cu.h to cu_main.c - Simplify code structure by merging the header file contents directly into cu_main.c. The cu_globals_s structure and related definitions are now directly in cu_main.c.
Impact
Fixes CI build error in system/cu.
Testing
Build tested with CONFIG_ENABLE_ALL_SIGNALS enabled.